Skip to content

8359477: com/sun/net/httpserver/Test12.java appears to have a temp file race #4055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

8359477: com/sun/net/httpserver/Test12.java appears to have a temp file race #4055

wants to merge 2 commits into from

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 16, 2025 •
edited by openjdk bot
Loading

Clean backport form 21.

Test does not compile as https://bugs.openjdk.org/browse/JDK-8277090 8277090: jsr166 refresh for jdk19
is not in 17. That change makes ExecutorService implement Autoclosable.

Replaced missing close() by its implementation.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8359477 needs maintainer approval

Issue

  • JDK-8359477: com/sun/net/httpserver/Test12.java appears to have a temp file race (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4055/head:pull/4055
$ git checkout pull/4055

Update a local copy of the PR:
$ git checkout pull/4055
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4055/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4055

View PR using the GUI difftool:
$ git pr show -t 4055

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4055.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 16, 2025 •
edited
Loading

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359477: com/sun/net/httpserver/Test12.java appears to have a temp file race

Reviewed-by: rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport e1681c48287bcce6c8f617d9c0c25354dd62870a 8359477: com/sun/net/httpserver/Test12.java appears to have a temp file race Oct 16, 2025
@openjdk
Copy link

openjdk bot commented Oct 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 16, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2025

Webrevs

@reinrich
Copy link
Member

Clean backport form 21.

The hascode

backport e1681c48287bcce6c8f617d9c0c25354dd62870a

is from 26 though.

reinrich
reinrich approved these changes Oct 20, 2025
View reviewed changes
Copy link
Member

@reinrich reinrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Cheers, Richard.

@openjdk
Copy link

openjdk bot commented Oct 20, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@GoeLin
Copy link
Member Author

GoeLin commented Oct 20, 2025

Hi @reinrich
thanks for the reviews.
Yes, after I saw that I had to edit the test I realized it't won't be clean and did not bother to update the hash. I started out with the PR for 21 ...

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 20, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Oct 20, 2025

/integrate

1 similar comment
@GoeLin
Copy link
Member Author

GoeLin commented Oct 20, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 20, 2025

Going to push as commit 0571351.
Since your change was applied there have been 18 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 20, 2025
@openjdk openjdk bot closed this Oct 20, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 20, 2025
@openjdk
Copy link

openjdk bot commented Oct 20, 2025

@GoeLin Pushed as commit 0571351.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Oct 20, 2025

@GoeLin The command integrate can only be used in open pull requests.

@GoeLin GoeLin deleted the goetz_backport_8359477 branch October 20, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@reinrich reinrich reinrich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GoeLin @reinrich